Issue 3326004: gclient: exponential backoff of SCM commands on known failure types....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3326004: gclient: exponential backoff of SCM commands on known failure types.... (Closed)

Created:
10 years, 3 months ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

gclient: exponential backoff of SCM commands on known failure types. This starts at 5 seconds (used to be 15) and goes up to ~60 seconds on the tenth round. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58488

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	gclient_scm.py	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
	M	scm.py	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cbentzel

Separate issue - it looks like the depot_tools gclient smoketest expects me to have svnadmin ...

10 years, 3 months ago (2010-09-02 15:04:18 UTC) #3

M-A Ruel

10 years, 3 months ago (2010-09-02 15:07:15 UTC) #4

On 2010/09/02 15:04:18, cbentzel wrote:
> Separate issue - it looks like the depot_tools gclient smoketest expects me
> to have svnadmin on my path (on Windows, not in cygwin).
> 
> Should svnadmin be included in depot_tools/svn?
> 
> On Thu, Sep 2, 2010 at 11:01 AM, <mailto:maruel@chromium.org> wrote:
> 
> > lgtm, thanks!
> >
> >
> > http://codereview.chromium.org/3326004/show
> >
> 

Oh, I had done it locally but forgot to commit that. In short, it means install
the svn server locally and recreate the zip file. In shorter, just ignore the
presubmit check and commit. :)

Expand Messages | Collapse Messages