Add ListFiles a function to recursively list files in a directory.

Add ListFiles a function to recursively list files in a directory.
Add unittest for ListFiles to cover common use cases.


BUG=
TEST=

[sosa, 2010-09-08 20:53:31]

Just some nits

http://codereview.chromium.org/3325017/diff/1/2
File chromite/lib/cros_build_lib.py (right):

http://codereview.chromium.org/3325017/diff/1/2#newcode132
chromite/lib/cros_build_lib.py:132: """Recurively list directories.
Recursively list files in directory.

http://codereview.chromium.org/3325017/diff/1/3
File chromite/lib/cros_build_lib_unittest.py (right):

http://codereview.chromium.org/3325017/diff/1/3#newcode1
chromite/lib/cros_build_lib_unittest.py:1: #!/usr/bin/python
One line after #!

http://codereview.chromium.org/3325017/diff/1/3#newcode27
chromite/lib/cros_build_lib_unittest.py:27: if err.errno == 17:
Is there a constant variable defined for this number somewhere in OSError?

http://codereview.chromium.org/3325017/diff/1/3#newcode63
chromite/lib/cros_build_lib_unittest.py:63: self.assertEqual(err.errno, 2)
Use the constant?

[scottz, 2010-09-08 21:03:49]

PTAL

http://codereview.chromium.org/3325017/diff/1/2
File chromite/lib/cros_build_lib.py (right):

http://codereview.chromium.org/3325017/diff/1/2#newcode132
chromite/lib/cros_build_lib.py:132: """Recurively list directories.
On 2010/09/08 20:53:31, sosa wrote:
> Recursively list files in directory.

Done.

http://codereview.chromium.org/3325017/diff/1/3
File chromite/lib/cros_build_lib_unittest.py (right):

http://codereview.chromium.org/3325017/diff/1/3#newcode1
chromite/lib/cros_build_lib_unittest.py:1: #!/usr/bin/python
On 2010/09/08 20:53:31, sosa wrote:
> One line after #!

Done.

http://codereview.chromium.org/3325017/diff/1/3#newcode27
chromite/lib/cros_build_lib_unittest.py:27: if err.errno == 17:
On 2010/09/08 20:53:31, sosa wrote:
> Is there a constant variable defined for this number somewhere in OSError?

Done.

http://codereview.chromium.org/3325017/diff/1/3#newcode63
chromite/lib/cros_build_lib_unittest.py:63: self.assertEqual(err.errno, 2)
On 2010/09/08 20:53:31, sosa wrote:
> Use the constant?

Done.

[scottz, 2010-09-08 21:06:26]

PTAL

[sosa, 2010-09-08 21:08:11]

LGTM w/ nit

http://codereview.chromium.org/3325017/diff/9001/10001
File chromite/lib/cros_build_lib.py (right):

http://codereview.chromium.org/3325017/diff/9001/10001#newcode143
chromite/lib/cros_build_lib.py:143: while len(directories) > 0:
Simplify to while directories: