Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: chrome/browser/renderer_host/render_view_host.h

Issue 3325012: Fix SessionStorage (Closed)
Patch Set: kill the last (new) dcheck Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/balloon_host.cc ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_view_host.h
diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h
index b8d6af522ce39dcfa8a9e7ad3d4cdba03ab4a5e6..4d50fb860fa4ae2a2316096a6a48bb5da7af4680 100644
--- a/chrome/browser/renderer_host/render_view_host.h
+++ b/chrome/browser/renderer_host/render_view_host.h
@@ -29,6 +29,7 @@ class FilePath;
class GURL;
class ListValue;
class RenderViewHostDelegate;
+class SessionStorageNamespace;
class SiteInstance;
class SkBitmap;
class ViewMsg_Navigate;
@@ -98,11 +99,14 @@ class RenderViewHost : public RenderWidgetHost {
static RenderViewHost* FromID(int render_process_id, int render_view_id);
// routing_id could be a valid route id, or it could be MSG_ROUTING_NONE, in
- // which case RenderWidgetHost will create a new one.
+ // which case RenderWidgetHost will create a new one. The session storage
+ // namespace parameter allows multiple render views to share the same session
+ // storage (part of the WebStorage spec) space. Passing in NULL simply
+ // allocates a new one (which is useful for testing).
RenderViewHost(SiteInstance* instance,
RenderViewHostDelegate* delegate,
int routing_id,
- int64 session_storage_namespace_id);
+ SessionStorageNamespace* session_storage_namespace);
virtual ~RenderViewHost();
SiteInstance* site_instance() const { return instance_; }
@@ -743,8 +747,8 @@ class RenderViewHost : public RenderWidgetHost {
// True if the render view can be shut down suddenly.
bool sudden_termination_allowed_;
- // The session storage namespace id to be used by the associated render view.
- int64 session_storage_namespace_id_;
+ // The session storage namespace to be used by the associated render view.
+ scoped_refptr<SessionStorageNamespace> session_storage_namespace_;
// Whether this render view will get extension api bindings. This controls
// what process type we use.
« no previous file with comments | « chrome/browser/notifications/balloon_host.cc ('k') | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698