Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 3325009: AU: when making a delta update, don't delta compress kernel partition. (Closed)

Created:
10 years, 3 months ago by adlr
Modified:
9 years ago
Reviewers:
Daniel Erat
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Base URL:
ssh://git@chromiumos-git/update_engine.git
Visibility:
Public.

Description

AU: when making a delta update, don't delta compress kernel partition. This is an unfortunate and hopefully temporarly measure to address a problem with the images people have in the field. People on dogfood devices (with traditional BIOS) may have a USB-signed or a HD-signed kernel partition. This was seen as okay since traditional BIOS doesn't use the kernel partition. However, this is a problem for delta updates, as when a delta from usb->usb kernel partitions is applied to an hd-kernel partition, the resultant kernel partition is invalid. While that may not seem like a problem (again, since traditional BIOS doesn't use it to boot), the postinst script at the end of update DOES look at the new kernel partition and bails if it's malformed, thus causing the update to fail. This CL causes delta images to send the kernel partition down in full (bzip2 compressed), which solves the immediate problem. The rootfs is still delta compressed. Longer term, we need to find a way to know exactly what's installed on the user's hard drive, including kernel partition, so that we can create a delta from it. BUG=chromium-os:6390 TEST=Tested update to a dogfood device with traditional BIOS.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M delta_diff_generator.cc View 1 chunk +13 lines, -14 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
adlr
Dan, sorry to pull you back into these reviews, but petkov is on vacation and ...
10 years, 3 months ago (2010-09-03 03:08:56 UTC) #1
Daniel Erat
10 years, 3 months ago (2010-09-03 05:43:21 UTC) #2
LGTM

http://codereview.chromium.org/3325009/diff/1/2
File delta_diff_generator.cc (right):

http://codereview.chromium.org/3325009/diff/1/2#newcode456
delta_diff_generator.cc:456: // Theres a single dest extent
nit: s/Theres/There's/

Powered by Google App Engine
This is Rietveld 408576698