Issue 3325005: Update gettoken.py to generate chromoting directory token.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3325005: Update gettoken.py to generate chromoting directory token. (Closed)

Created:
10 years, 3 months ago by garykac

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, pam+watch_chromium.org, awong, garykac

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Update gettoken.py to generate chromoting directory token. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58495

Patch Set 1 #

Total comments: 1

Patch Set 2 : reindent #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
	M	remoting/tools/gettoken.py	View	1	1 chunk	+32 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

10 years, 3 months ago (2010-09-02 02:07:28 UTC) #2

LGTM

http://codereview.chromium.org/3325005/diff/1/2
File remoting/tools/gettoken.py (right):

http://codereview.chromium.org/3325005/diff/1/2#newcode30
remoting/tools/gettoken.py:30: chromoting_dir_auth_token =
chromoting_dir_authenticator.authenticate(email,
I would wrap this line after '=' instead of in the middle of parameter list.

Expand Messages | Collapse Messages