Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 3324013: Merge 66911 - 2010-09-07 Abhishek Arya <inferno@chromium.org>... (Closed)

Created:
10 years, 3 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 66911 - 2010-09-07 Abhishek Arya <inferno@chromium.org>; Reviewed by Darin Adler. Remove redundant bounds check in originalText(). Add bounds check to previousCharacter(). No need of start() > 0 check since m_start is unsigned and we already do start() null check inside function. https://bugs.webkit.org/show_bug.cgi?id=45303 Test: fast/text/one-letter-transform-crash.html * rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter): 2010-09-07 Abhishek Arya <inferno@chromium.org>; Reviewed by Darin Adler. Tests that we dont hit assert i < m_length when trying to read previousCharacter for text fragments. https://bugs.webkit.org/show_bug.cgi?id=45303 * fast/text/one-letter-transform-crash-expected.txt: Added. * fast/text/one-letter-transform-crash.html: Added. BUG=54539 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A + LayoutTests/fast/text/one-letter-transform-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text/one-letter-transform-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/rendering/RenderTextFragment.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 3 months ago (2010-09-09 21:31:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698