Issue 3323005: Unrevert 58354, reland PPAPI with the instance test disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3323005: Unrevert 58354, reland PPAPI with the instance test disabled. (Closed)

Created:
10 years, 3 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, jam, dmac, darin-cc_chromium.org, awong, garykac, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unrevert 58354, reland PPAPI with the instance test disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58358

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -58 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ppapi_uitest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/client/plugin/pepper_entrypoints.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.cc	View	4 chunks	+50 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_var.h	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_var.cc	View	4 chunks	+47 lines, -56 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM We argued back and forth for a while about whether to revert or disable ...

10 years, 3 months ago (2010-09-02 16:03:15 UTC) #2

brettw

10 years, 3 months ago (2010-09-02 16:08:00 UTC) #3

On Thu, Sep 2, 2010 at 9:03 AM, Rohit Rao <rohitrao@chromium.org> wrote:
> LGTM
>
> We argued back and forth for a while about whether to revert or disable =)

Reverting this causes anybody working on PPAPI to be unable to sync or
commit because ToT Chrome won't build with ToT PPAPI.

Brett

Expand Messages | Collapse Messages