Issue 3323004: missed feedback from CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3323004: missed feedback from CL (Closed)

Created:
10 years, 3 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
kliegs, Vince Laviano

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

missed feedback from CL

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build_image	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

10 years, 3 months ago (2010-09-02 19:41:15 UTC) #4

No, it's just style / code cleanliness changes.

On Thu, Sep 2, 2010 at 7:27 AM, <kliegs@chromium.org> wrote:

> Is there a bug for this?
>
>
> http://codereview.chromium.org/3323004/show
>

Expand Messages | Collapse Messages