Add autotest which accounts for all process privileges

Add autotest which accounts for all process privileges

Change-Id: Ic67e2acbe626d0764e1b6e8ee858814f0db05449

BUG=(none)
TEST=Ran run_remote_tests with this test on cros.

[seano, 2010-09-08 14:31:15]

http://codereview.chromium.org/3322015/diff/3001/4002
File client/site_tests/platform_ProcessPrivilegesComprehensive/control (right):

http://codereview.chromium.org/3322015/diff/3001/4002#newcode21
client/site_tests/platform_ProcessPrivilegesComprehensive/control:21: processes
of the same name, but running at different privilege levels.
Please simplify this to explain exactly what the test does when run. What it
"can" do seems unclear to me. What precisely does it do when run?

If functionality changes in the future, we'll just update the docstring.

http://codereview.chromium.org/3322015/diff/3001/4003
File
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py
(right):

http://codereview.chromium.org/3322015/diff/3001/4003#newcode31
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:31:
self.baseline = eval(bfile.read())
Please import json and use json.loads() instead of eval.

http://codereview.chromium.org/3322015/diff/3001/4003#newcode141
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:141:
time.sleep(10)
I believe site_uitest automatically calls login() from Initialize.. do you need
to call this?

also, its login() method already has a call to ensure_login_complete. Please
either trust it to check the right condition, or subclass it in your test class
to intelligently check/poll for the right condition. We're trying to avoid hard
coding calls to sleep() (which aren't safe to rely on anyway.)

-S

[jimhebert, 2010-09-08 20:21:54]

PTAL Thanks!

On 2010/09/08 14:31:15, seano wrote:
> http://codereview.chromium.org/3322015/diff/3001/4002
> File client/site_tests/platform_ProcessPrivilegesComprehensive/control
(right):
> 
> http://codereview.chromium.org/3322015/diff/3001/4002#newcode21
> client/site_tests/platform_ProcessPrivilegesComprehensive/control:21:
processes
> of the same name, but running at different privilege levels.
> Please simplify this to explain exactly what the test does when run. What it
> "can" do seems unclear to me. What precisely does it do when run?

fixed

> 
> If functionality changes in the future, we'll just update the docstring.
> 
> http://codereview.chromium.org/3322015/diff/3001/4003
> File
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py
> (right):
> 
> http://codereview.chromium.org/3322015/diff/3001/4003#newcode31
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:31:
> self.baseline = eval(bfile.read())
> Please import json and use json.loads() instead of eval.

fixed. (Sorry for the big noisy diff in the baseline file, making this
compatible with json.loads() involved punctuation changes on every line.)

> 
> http://codereview.chromium.org/3322015/diff/3001/4003#newcode141
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:141:
> time.sleep(10)
> I believe site_uitest automatically calls login() from Initialize.. do you
need
> to call this?
> 
> also, its login() method already has a call to ensure_login_complete. Please
> either trust it to check the right condition, or subclass it in your test
class
> to intelligently check/poll for the right condition. We're trying to avoid
hard
> coding calls to sleep() (which aren't safe to rely on anyway.)

I agree, I've removed these. That code was copy-pasted from some other test,
unfortunately.

[fes, 2010-09-10 17:34:30]

LGTM

[seano, 2010-09-13 08:52:38]

LGTM, thanks!

Which other test? We should find it and fix it :)

On 2010/09/08 20:21:54, jimhebert wrote:
> PTAL Thanks!
> 
> On 2010/09/08 14:31:15, seano wrote:
> > http://codereview.chromium.org/3322015/diff/3001/4002
> > File client/site_tests/platform_ProcessPrivilegesComprehensive/control
> (right):
> > 
> > http://codereview.chromium.org/3322015/diff/3001/4002#newcode21
> > client/site_tests/platform_ProcessPrivilegesComprehensive/control:21:
> processes
> > of the same name, but running at different privilege levels.
> > Please simplify this to explain exactly what the test does when run. What it
> > "can" do seems unclear to me. What precisely does it do when run?
> 
> fixed
> 
> > 
> > If functionality changes in the future, we'll just update the docstring.
> > 
> > http://codereview.chromium.org/3322015/diff/3001/4003
> > File
> >
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py
> > (right):
> > 
> > http://codereview.chromium.org/3322015/diff/3001/4003#newcode31
> >
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:31:
> > self.baseline = eval(bfile.read())
> > Please import json and use json.loads() instead of eval.
> 
> fixed. (Sorry for the big noisy diff in the baseline file, making this
> compatible with json.loads() involved punctuation changes on every line.)
> 
> > 
> > http://codereview.chromium.org/3322015/diff/3001/4003#newcode141
> >
>
client/site_tests/platform_ProcessPrivilegesComprehensive/platform_ProcessPrivilegesComprehensive.py:141:
> > time.sleep(10)
> > I believe site_uitest automatically calls login() from Initialize.. do you
> need
> > to call this?
> > 
> > also, its login() method already has a call to ensure_login_complete. Please
> > either trust it to check the right condition, or subclass it in your test
> class
> > to intelligently check/poll for the right condition. We're trying to avoid
> hard
> > coding calls to sleep() (which aren't safe to rely on anyway.)
> 
> I agree, I've removed these. That code was copy-pasted from some other test,
> unfortunately.