Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: build/common.gypi

Issue 332035: linux: add -fvisibility=hidden to build flags (Closed)
Patch Set: fix for shared Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webkit/tools/npapi_layout_test_plugin/main.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 # Enable -Werror by default, but put it in a variable so it can 486 # Enable -Werror by default, but put it in a variable so it can
487 # be disabled in ~/.gyp/include.gypi on the valgrind builders. 487 # be disabled in ~/.gyp/include.gypi on the valgrind builders.
488 'variables': { 488 'variables': {
489 'werror%': '-Werror', 489 'werror%': '-Werror',
490 'no_strict_aliasing%': 0, 490 'no_strict_aliasing%': 0,
491 }, 491 },
492 'cflags': [ 492 'cflags': [
493 '<(werror)', # See note above about the werror variable. 493 '<(werror)', # See note above about the werror variable.
494 '-pthread', 494 '-pthread',
495 '-fno-exceptions', 495 '-fno-exceptions',
496 '-fvisibility=hidden',
496 '-Wall', 497 '-Wall',
497 '-D_FILE_OFFSET_BITS=64', 498 '-D_FILE_OFFSET_BITS=64',
498 ], 499 ],
499 'cflags_cc': [ 500 'cflags_cc': [
500 #'-fno-rtti', 501 #'-fno-rtti',
501 '-fno-threadsafe-statics', 502 '-fno-threadsafe-statics',
502 ], 503 ],
503 'ldflags': [ 504 'ldflags': [
504 '-pthread', 505 '-pthread',
505 ], 506 ],
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 }], 688 }],
688 ['no_strict_aliasing==1', { 689 ['no_strict_aliasing==1', {
689 'cflags': [ 690 'cflags': [
690 '-fno-strict-aliasing', 691 '-fno-strict-aliasing',
691 ], 692 ],
692 }], 693 }],
693 ['linux_breakpad==1', { 694 ['linux_breakpad==1', {
694 'cflags': [ '-gstabs' ], 695 'cflags': [ '-gstabs' ],
695 'defines': ['USE_LINUX_BREAKPAD'], 696 'defines': ['USE_LINUX_BREAKPAD'],
696 }], 697 }],
698 ['library=="shared_library"', {
699 # When building with shared libraries, remove the visiblity-hiding
700 # flag.
701 'cflags!': [ '-fvisibility=hidden' ],
702 }],
697 ], 703 ],
698 }, 704 },
699 }], 705 }],
700 ['OS=="mac"', { 706 ['OS=="mac"', {
701 'target_defaults': { 707 'target_defaults': {
702 'variables': { 708 'variables': {
703 # This should be 'mac_real_dsym%', but there seems to be a bug 709 # This should be 'mac_real_dsym%', but there seems to be a bug
704 # with % in variables that are intended to be set to different 710 # with % in variables that are intended to be set to different
705 # values in different targets, like this one. 711 # values in different targets, like this one.
706 'mac_real_dsym': 0, # Fake .dSYMs are fine in most cases. 712 'mac_real_dsym': 0, # Fake .dSYMs are fine in most cases.
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 # and therefore SYMROOT, needs to be set at the project level. 935 # and therefore SYMROOT, needs to be set at the project level.
930 'SYMROOT': '<(DEPTH)/xcodebuild', 936 'SYMROOT': '<(DEPTH)/xcodebuild',
931 }, 937 },
932 } 938 }
933 939
934 # Local Variables: 940 # Local Variables:
935 # tab-width:2 941 # tab-width:2
936 # indent-tabs-mode:nil 942 # indent-tabs-mode:nil
937 # End: 943 # End:
938 # vim: set expandtab tabstop=2 shiftwidth=2: 944 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | webkit/tools/npapi_layout_test_plugin/main.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698