Issue 332033: Make the web plugin proxy tolerant of windowless bitmap memory mapping failur...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332033: Make the web plugin proxy tolerant of windowless bitmap memory mapping failur... (Closed)

Created:
11 years, 1 month ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the web plugin proxy tolerant of windowless bitmap memory mapping failures. These seem to be happening at a low frequency, and can be a result of being out of memory or using too many GDI resources (I think). By catching the error and clearing the canvas pointers, we won't crash and will just skip drawing the plugin. TEST=none BUG=25689 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30201

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
	M	chrome/plugin/webplugin_proxy.cc	View	1 2	1 chunk	+26 lines, -13 lines	0 comments	Download
	M	chrome/test/data/reliability/known_crashes.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

11 years, 1 month ago (2009-10-26 21:37:58 UTC) #2

On 2009/10/26 20:49:07, brettw wrote:
> 

LGTM.

Expand Messages | Collapse Messages