Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 332021: Move page actions over to ExtensionAction2 (Closed)
Patch Set: Review feedback Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_service.cc
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index 354d7d2a1e4dfb9d930c003bd693bfba5bc38a99..ef6d9cdf1012d3cb026b3effbbd646f0a58a7b1d 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -140,19 +140,6 @@ void ExtensionsService::Init() {
GarbageCollectExtensions();
}
-std::vector<ExtensionAction*> ExtensionsService::GetPageActions() const {
- std::vector<ExtensionAction*> result;
-
- // TODO(finnur): Sort the icons in some meaningful way.
- for (ExtensionList::const_iterator iter = extensions_.begin();
- iter != extensions_.end(); ++iter) {
- if ((*iter)->page_action())
- result.push_back((*iter)->page_action());
- }
-
- return result;
-}
-
void ExtensionsService::InstallExtension(const FilePath& extension_path) {
CrxInstaller::Start(extension_path, install_directory_, Extension::INTERNAL,
"", // no expected id

Powered by Google App Engine
This is Rietveld 408576698