Issue 332007: Fix issue with running some constructors having only this.x = ... assignments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332007: Fix issue with running some constructors having only this.x = ... assignments (Closed)

Created:
11 years, 2 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix issue with running some constructors having only this.x = ... assignments. If we had compiled the comment instead of the code it would have worked. BUG=483 TEST=mjsunit/regress/regress-483.js Committed: http://code.google.com/p/v8/source/detail?r=3120

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	src/heap.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download
	A	test/mjsunit/regress/regress-483.js	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 2 months ago (2009-10-23 12:17:40 UTC) #2

LGTM!

http://codereview.chromium.org/332007/diff/1/3
File src/heap.cc (right):

http://codereview.chromium.org/332007/diff/1/3#newcode2259
Line 2259: if (fun->shared()->has_only_this_property_assignments() &&
Does has_only_simple_this_property_assignments imply
has_only_this_property_assignments?  If it does you can remove the first line
here.

Expand Messages | Collapse Messages