Issue 3320003: Allows chromoting host to be connected again after connection drops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3320003: Allows chromoting host to be connected again after connection drops. (Closed)

Created:
10 years, 3 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Alpha Left Google

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Allows chromoting host to be connected again after connection drops. BUG=52890 TEST=Connects to chromoting disconnect, and then try again This allows basic reconnect functions of the chromoting host. We still have the following problems: 1. We don't have a disconnect command. 2. If we are waiting for client connection to time out we don't allow second connection. 3. Need to force a full frame update after a new client is connected. I am going to solve the above problems in separate patches but this patch will allow basic reconnect to work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58441

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	remoting/host/chromoting_host.cc	View		4 chunks	+4 lines, -2 lines	1 comment	Download
	M	remoting/host/session_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

10 years, 3 months ago (2010-09-02 01:20:24 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/3320003/diff/1/2
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/3320003/diff/1/2#newcode73
remoting/host/chromoting_host.cc:73: session_->AddClient(client);
This code is duplicated below. Move this out of the if block?

Expand Messages | Collapse Messages