Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 3319008: Add options argument to _Run() to redirect output. (Closed)

Created:
10 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add options argument to _Run() to redirect output. Add automatic 'header' on command execution BUG=54084 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58700

Patch Set 1 #

Patch Set 2 : fix smoke tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M gclient_scm.py View 1 8 chunks +11 lines, -13 lines 0 comments Download
M tests/gclient_smoketest.py View 9 chunks +28 lines, -50 lines 0 comments Download
M trychange.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
10 years, 3 months ago (2010-09-03 19:43:49 UTC) #1
bradn
LGTM
10 years, 3 months ago (2010-09-03 20:29:04 UTC) #2
M-A Ruel
FYI, I had forgot to update the smoke tests.
10 years, 3 months ago (2010-09-07 16:10:38 UTC) #3
bradn
10 years, 3 months ago (2010-09-07 16:57:41 UTC) #4
Looks, even better :-)

Powered by Google App Engine
This is Rietveld 408576698