Mac: Make resizing the window larger nicer when compositor is active

Mac: Make resizing the window larger nicer when compositor is active

We need to fill the part of the RWHVMac not covered by the compositor subview with white.

Resizing smaller is still a bit jumpy. We also still paint an uninitialized IOSurface every now and then.

BUG=53165
TEST=Enable compositor, make window larger. Right bottom part of window shouldn't be transparent.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58504

[pink (ping after 24hrs), 2010-09-03 16:29:39]

lgtm, but please fix the style issues.

http://codereview.chromium.org/3319004/diff/4001/5002
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1439
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1439: -
(void)fillBottomRightRemainderOfRect:(gfx::Rect)bitmap_rect
method needs a comment

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1439
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1439: -
(void)fillBottomRightRemainderOfRect:(gfx::Rect)bitmap_rect
objectiveC method uses obj-c naming. bitmapRect, damagedRect, etc.

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1493
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1493: const
gfx::Rect damaged_rect([self flipNSRectToRect:dirtyRect]);
damagedRect. This whole method is a walking style violation :-)

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1496
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1496: gfx::Rect
gpu_rect;
gpuRect

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1498
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1498:
gfx::PluginWindowHandle root_handle =
rootHandle

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1526
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1526: gfx::Rect
bitmap_rect(0, 0,
bitmapRect....etc etc

[Nico, 2010-09-03 16:31:41]

http://codereview.chromium.org/3319004/diff/4001/5002
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3319004/diff/4001/5002#newcode1493
chrome/browser/renderer_host/render_widget_host_view_mac.mm:1493: const
gfx::Rect damaged_rect([self flipNSRectToRect:dirtyRect]);
On 2010/09/03 16:29:39, pink wrote:
> damagedRect. This whole method is a walking style violation :-)

I figured I'll send it out without this changes, makes it easier to see that the
new method above is just moved code. Will fix now.

[pink (ping after 24hrs), 2010-09-03 16:32:41]

makes sense, thanks for cleaning it up.

On Fri, Sep 3, 2010 at 12:31 PM,  <thakis@chromium.org> wrote:
>
> http://codereview.chromium.org/3319004/diff/4001/5002
> File chrome/browser/renderer_host/render_widget_host_view_mac.mm
> (right):
>
> http://codereview.chromium.org/3319004/diff/4001/5002#newcode1493
> chrome/browser/renderer_host/render_widget_host_view_mac.mm:1493: const
> gfx::Rect damaged_rect([self flipNSRectToRect:dirtyRect]);
> On 2010/09/03 16:29:39, pink wrote:
>>
>> damagedRect. This whole method is a walking style violation :-)
>
> I figured I'll send it out without this changes, makes it easier to see
> that the new method above is just moved code. Will fix now.
>
> http://codereview.chromium.org/3319004/show
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[Nico, 2010-09-03 16:37:50]

Should now all be cleaned up. Will land once trybots are green.