Issue 3318005: Use correct log functions for enter_chroot's console spew.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3318005: Use correct log functions for enter_chroot's console spew. (Closed)

Created:
10 years, 3 months ago by seano

Modified:
9 years, 7 months ago

Reviewers:
kliegs, ellyjones

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Use correct log functions for enter_chroot's console spew. Change-Id: Ie0e05626e3619584d565ff3414f1d1b073c7fc7f BUG= TEST=Manually

Patch Set 1 #

Patch Set 2 : fix accidental clobbering of ellyjones change #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	enter_chroot.sh	View	1	8 chunks	+20 lines, -20 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kliegs

Looks like this conflicts with a change just submitted. Can you please resync/remerge and upload ...

10 years, 3 months ago (2010-09-02 14:49:39 UTC) #2

seano

Oops, old emacs buffer bit me. Fixed, PTAL On 2010/09/02 14:49:39, kliegs wrote: > Looks ...

10 years, 3 months ago (2010-09-02 15:04:08 UTC) #3

kliegs

LGTM. NIT: Line 145 should be changed to a conditional info or error message based ...

10 years, 3 months ago (2010-09-02 15:34:17 UTC) #4

kliegs

10 years, 3 months ago (2010-09-02 15:34:30 UTC) #5

http://codereview.chromium.org/3318005/diff/4001/5001
File enter_chroot.sh (right):

http://codereview.chromium.org/3318005/diff/4001/5001#newcode145
enter_chroot.sh:145: info "Not mounting chrome source"
NIT: This should be switched to conditional and be an info if CHROME_ROOT is not
set and an error if it is.

Expand Messages | Collapse Messages