Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 3317007: Fix collection of kernel crash into /var/spool/crash (Closed)

Created:
10 years, 3 months ago by hughd
Modified:
9 years, 7 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/crash-reporter.git
Visibility:
Public.

Description

Fix collection of kernel crash into /var/spool/crash No kcrash was collected because the IsEnabled() test always failed: we must do the kernel_collector->Enable() first. I've not checked if this might break the Override path (for local testing): it's more important for the feature to work for real than in an artificial test. BUG=837, 5865 TEST=logging_KernelCrashServer or manual procedure Signed-off-by: Hugh Dickins <hughd@chromium.org>;

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M crash_reporter.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hughd
10 years, 3 months ago (2010-09-04 03:53:51 UTC) #1
kmixter1
LGTM provided it now passes logging_KernelCrash. I remember refactoring this and I thought I ran ...
10 years, 3 months ago (2010-09-09 03:29:07 UTC) #2
hughd
10 years, 3 months ago (2010-09-09 03:37:43 UTC) #3
Indeed it does now pass logging_KernelCrash: I just re-ran it to check,
Total PASS: 4/4 (100%)

Powered by Google App Engine
This is Rietveld 408576698