Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 3316011: Merge 66886 - 2010-09-07 Jonathan Dixon <joth@chromium.org>... (Closed)

Created:
10 years, 3 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 66886 - 2010-09-07 Jonathan Dixon <joth@chromium.org>; Reviewed by Jeremy Orlow. Access to out-of-scope WebGeolocationServiceBridgeImpl https://bugs.webkit.org/show_bug.cgi?id=45112 Add missing virtual destructor to the abstract base class. * platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge): * platform/chromium/GeolocationServiceChromium.h: 2010-09-07 Jonathan Dixon <joth@chromium.org>; Reviewed by Jeremy Orlow. Access to out-of-scope WebGeolocationServiceBridgeImpl https://bugs.webkit.org/show_bug.cgi?id=45112 Keep the WebGeolocationService pointer for lifetime of the bridge, to ensure it can be detached reliably * public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge): * src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): BUG=53394 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -36 lines) Patch
M WebCore/platform/chromium/GeolocationServiceChromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M WebCore/platform/chromium/GeolocationServiceChromium.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M WebKit/chromium/public/WebGeolocationService.h View 2 chunks +5 lines, -2 lines 0 comments Download
M WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp View 3 chunks +50 lines, -34 lines 0 comments Download
M WebKit/chromium/src/WebGeolocationServiceMock.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 3 months ago (2010-09-09 17:56:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698