Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 3315020: Prototype cros_build_packages, which builds and extracts build tarballs. (Closed)

Created:
10 years, 3 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Prototype cros_build_packages, which builds and extracts build tarballs. Usage: cros_build_packages [options] Options: -h, --help show this help message and exit --board=BOARD The board to build packages for. --debug Include debug symbols. --nowithdev Don't build useful developer friendly utilities. --nowithtest Build packages required for testing. --nowithfactory Build factory installer --nousepkg Don't use binary packages. --nousetarball Don't use tarball. --nofast Don't merge packages in parallel. BUG=chromium-os:6604 TEST=Ran cros_build_packages and ./cros_build_packages --nousetarball

Patch Set 1 #

Total comments: 10

Patch Set 2 : Add TODOs #

Patch Set 3 : Add back blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -0 lines) Patch
A chromite/bin/cros_build_packages View 1 2 1 chunk +275 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
anush
10 years, 3 months ago (2010-09-10 19:07:23 UTC) #1
LGTM with TODOs.

http://codereview.chromium.org/3315020/diff/1/2
File chromite/bin/cros_build_packages (right):

http://codereview.chromium.org/3315020/diff/1/2#newcode19
chromite/bin/cros_build_packages:19: """Build packages according to options
specified on command-line."""
it may not be specified on the command line :)

http://codereview.chromium.org/3315020/diff/1/2#newcode35
chromite/bin/cros_build_packages:35:
packages.append("chromeos-base/chromeos-test")
All of the above options will come from the profile (and hence the spec file).
Please add a TODO

http://codereview.chromium.org/3315020/diff/1/2#newcode56
chromite/bin/cros_build_packages:56: prefix =
"http://commondatastorage.googleapis.com/chromeos-prebuilt/board"
TODO: has to point to a profile image such as base/ dev/ test etc

http://codereview.chromium.org/3315020/diff/1/2#newcode101
chromite/bin/cros_build_packages:101: retries: If exit code is non-zero, retry
this many times.
should this be in the common lib itself to allow anyone to run commands with
retries.

http://codereview.chromium.org/3315020/diff/1/2#newcode113
chromite/bin/cros_build_packages:113: def _RunMany(cmds, retries=0):
Again something for common lib? And possibly called RunManyParallel ? Since
RunMany could default to a set of commands executed serially.

http://codereview.chromium.org/3315020/diff/1/2#newcode153
chromite/bin/cros_build_packages:153: _Run("%s/setup_board --force --board=%s" %
(self.scripts_dir, board))
TODO: extract setup_board logic in here. Also have to handle existing buildroots
gracefully either pulled in via prebuild tarballs. This wont be an issue once we
start using unique buildnumbers

http://codereview.chromium.org/3315020/diff/1/2#newcode187
chromite/bin/cros_build_packages:187: # the background.
TODO: use unique build numbers. Will need a way to clean up old builds and
reusing builds.

http://codereview.chromium.org/3315020/diff/1/2#newcode224
chromite/bin/cros_build_packages:224: help="The board to build packages for.")
As discussed offline we will move to using the spec file for these options.
Please add a TODO for it.

http://codereview.chromium.org/3315020/diff/1/2#newcode226
chromite/bin/cros_build_packages:226: default=False, help="Include debug
symbols.")
this should come in from FEATURES="test" in the make.conf of the profile

http://codereview.chromium.org/3315020/diff/1/2#newcode237
chromite/bin/cros_build_packages:237: help="Don't use binary packages.")
The above 4 will also come from the .spec file of the profile.

Powered by Google App Engine
This is Rietveld 408576698