Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 3315002: Add api constants for webRequest and clean up webNavigation. (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
yzshen, Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add api constants for webRequest and clean up webNavigation. BUG=50943 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58330

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -10 lines) Patch
A + chrome/browser/extensions/extension_webnavigation_api_constants.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + chrome/browser/extensions/extension_webnavigation_api_constants.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A chrome/browser/extensions/extension_webrequest_api_constants.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_webrequest_api_constants.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 3 months ago (2010-09-01 13:10:01 UTC) #1
Matt Perry
LGTM
10 years, 3 months ago (2010-09-01 19:00:28 UTC) #2
yzshen
10 years, 3 months ago (2010-09-01 23:17:39 UTC) #3
On 2010/09/01 13:10:01, jochen wrote:
> please review

Hi, Jochen.

You might consider adding value constants for request types (e.g., "main_frame",
"sub_frame", etc.), transition qualifiers ("client_redirect", "server_redirect",
etc.), and probably transition types.

Powered by Google App Engine
This is Rietveld 408576698