Issue 3311008: commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3311008: commit (Closed)

Created:
10 years, 3 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
truty

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Move Chrome SyncIntegrationTests from nightly to browser test suite. Change-Id: I71f2c10253ff1f3a95b6c9f7ce0f06c0eb324d5c BUG= TEST=Run control.browser_test suite manually.

Patch Set 3 : patch #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -11 lines)			Patch
	M	server/site_tests/suite_Nightly/control	View	1 2	2 chunks	+7 lines, -8 lines	0 comments	Download
	M	server/site_tests/suite_Nightly/control.browsertest	View	1	1 chunk	+22 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

truty

LGTM with a nit. http://codereview.chromium.org/3311008/diff/1/3 File server/site_tests/suite_Nightly/control.browsertest (right): http://codereview.chromium.org/3311008/diff/1/3#newcode18 server/site_tests/suite_Nightly/control.browsertest:18: from autotest_lib.server import site_host_attributes don't ...

10 years, 3 months ago (2010-09-02 18:55:15 UTC) #2

ericli

10 years, 3 months ago (2010-09-02 18:59:10 UTC) #3

Fixed.

Pushing...

On Thu, Sep 2, 2010 at 11:55 AM, <truty@chromium.org> wrote:

> LGTM with a nit.
>
>
> http://codereview.chromium.org/3311008/diff/1/3
> File server/site_tests/suite_Nightly/control.browsertest (right):
>
> http://codereview.chromium.org/3311008/diff/1/3#newcode18
> server/site_tests/suite_Nightly/control.browsertest:18: from
>
> autotest_lib.server import site_host_attributes
> don't need this.
>
>
> http://codereview.chromium.org/3311008/show
>



-- 
Eric Li
李咏竹
Google Kirkland

Expand Messages | Collapse Messages

Issue 3311008: commit (Closed)

Description

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Messages