Issue 3311002: Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3311002: Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in t... (Closed)

Created:
10 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in test-log-stack-tracer.cc with an alternative implementation. Committed: http://code.google.com/p/v8/source/detail?r=5392

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 10 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -76 lines)
M	src/arm/codegen-arm.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	src/codegen.h	View	1 chunk	+0 lines, -1 line	0 comments
M	src/codegen.cc	View	1 chunk	+0 lines, -15 lines	0 comments
M	src/ia32/codegen-ia32.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	src/mips/codegen-mips.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	src/x64/codegen-x64.h	View	1 chunk	+1 line, -3 lines	0 comments
M	test/cctest/test-log-stack-tracer.cc	View	5 chunks	+76 lines, -48 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

A new implementation of the frame-pointer-grabber in test-stack-tracer.

10 years, 3 months ago (2010-09-01 12:46:39 UTC) #1

mnaganov (inactive)

10 years, 3 months ago (2010-09-01 12:57:04 UTC) #2

LGTM with a comment.

Awesome! Thanks for fixing this!

http://codereview.chromium.org/3311002/diff/9/16007
File test/cctest/test-log-stack-tracer.cc (right):

http://codereview.chromium.org/3311002/diff/9/16007#newcode249
test/cctest/test-log-stack-tracer.cc:249:
ASSERT(frame_iterator.frame()->is_exit());
maybe replace this with a CHECK, so it will abort in release mode, too?

Expand Messages | Collapse Messages