Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: gclient.py

Issue 3310026: Automatically disable progress for non tty output, i.e. when it's redirected. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 650c25a46ee4a0c2f06b5f9714505c24555a78cb..3850ed94235cfa33baedffd6e13af2396f0099da 100644
--- a/gclient.py
+++ b/gclient.py
@@ -715,7 +715,8 @@ solutions = [
raise gclient_utils.Error('No solution specified')
revision_overrides = self._EnforceRevisions()
pm = None
- if command == 'update' and not self._options.verbose:
+ # Disable progress for non-tty stdout.
+ if command in ('update', 'revert') and sys.stdout.isatty():
pm = Progress('Syncing projects', 1)
work_queue = gclient_utils.ExecutionQueue(self._options.jobs, pm)
for s in self.dependencies:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698