Avoid (some) symbol lookups at parse time if preparse data is available.

Avoid (some) symbol lookups at parse time if preparse data is available.

[Mads Ager (chromium), 2010-09-06 12:03:56]

Is the test coverage good enough. Do we have preparsing tests that actually
exercise this code?

If we do, LGTM.

http://codereview.chromium.org/3308010/diff/1/3
File src/parser.cc (right):

http://codereview.chromium.org/3308010/diff/1/3#newcode899
src/parser.cc:899: Vector<const char> string) {
Identation.

http://codereview.chromium.org/3308010/diff/1/4
File src/parser.h (right):

http://codereview.chromium.org/3308010/diff/1/4#newcode141
src/parser.h:141: // The following functions should only be cast after
SanityCheck has returned
cast -> called?

http://codereview.chromium.org/3308010/diff/1/4#newcode152
src/parser.h:152: - (function_index_ - kHeaderSize));
This looks like funky indentation to me. I would add a pair of parenthesis and
do:

ASSERT(function_entries 
       <= (static_cast<int>(store_[kFunctionsSizeOffset])
           - (function_index_ - kHeaderSize)));

[Lasse Reichstein, 2010-09-07 12:01:31]

Added test.
Fixed a bug in preparser data with error messages.
Made messages code more readable.
Please review test.

[Mads Ager (chromium), 2010-09-07 12:44:53]

LGTM

http://codereview.chromium.org/3308010/diff/7001/8006
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/3308010/diff/7001/8006#newcode205
test/cctest/test-parsing.cc:205: // Parser needs a handle scope.
This comment doesn't seem to fit here?