Remove one-time flags when restarting after update....

Remove one-time flags when restarting after update.

BUG=53407
TEST=SwitchUtilsTest.AddRemoveSwitches


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60161

[Finnur, 2010-09-14 11:26:45]

ping

[Finnur, 2010-09-17 15:03:03]

ping

On 2010/09/14 11:26:45, Finnur wrote:
> ping

[Finnur, 2010-09-20 15:40:14]

Welcome back, Andrew. :)

On 2010/09/17 15:03:03, Finnur wrote:
> ping
> 
> On 2010/09/14 11:26:45, Finnur wrote:
> > ping

[Andrew T Wilson (Slow), 2010-09-21 03:40:33]

Sorry for the late response on this - I was on vacation :(

http://codereview.chromium.org/3307024/diff/12001/13001
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/3307024/diff/12001/13001#newcode754
chrome/browser/browser_process_impl.cc:754:
switches::AddSwitchesForAutostart(new_cl.get());
So I think refactoring out the removal of the one-time switches into a common
routine is a great change. I think that adding "kNoStartupWindow" is really only
useful in this one specific case (restarting the browser when running in
background mode) so I think we should probably not refactor that into a common
AddSwitchesForAutostart() routine since it's not likely to be useful elsewhere. 

Or if we do refactor it, we should name the routine something explicit like
"AddSwitchesToRestartInBackgroundMode()" or something similar, but I'd lean
towards just leaving that code in this routine instead (i.e. move
AddSwitchesForAutostart() back into this file and only keep
RemoveSwitchesForAutostart() as common code).

http://codereview.chromium.org/3307024/diff/12001/13007
File chrome/common/switch_utils_unittest.cc (right):

http://codereview.chromium.org/3307024/diff/12001/13007#newcode48
chrome/common/switch_utils_unittest.cc:48: EXPECT_EQ(3U, switches.size());
This test looks pretty good - to be extra sure, I'm wondering if you should add
a couple of EXPECT_TRUE(cmd_line.HasSwitch("foo") and HasSwitch("bar")
statements in here, just to make sure that the remaining switches are the ones
you expect?

[Finnur, 2010-09-21 11:43:19]

> Sorry for the late response on this - I was on vacation :(

Slacker... I mean: No problem. :)

Good suggestions. Updated CL.

[Andrew T Wilson (Slow), 2010-09-21 17:33:16]

LGTM