Issue 3307022: Issue 6600: RunCommand should return an object with various attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3307022: Issue 6600: RunCommand should return an object with various attributes (Closed)

Created:
10 years, 3 months ago by Tan Gao

Modified:
9 years, 7 months ago

Reviewers:
davidjames, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, colinc, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Issue 6600: RunCommand should return an object with various attributes Change-Id: I6b9333fcf1325dbe141ad387f52d85781de96819 BUG=chromium-os:6600 TEST=added 8 test cases for RunCommand (up from zero :-) Ran all tests and verified all passed. No regression either

Patch Set 1 #

Patch Set 2 : add copyright notice #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -17 lines)			Patch
	M	chromite/lib/cros_build_lib.py	View		3 chunks	+25 lines, -6 lines	0 comments	Download
	M	chromite/lib/cros_build_lib_unittest.py	View	1	4 chunks	+115 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tan Gao

Hi Chris/David, This CL changes RunCommand to return an object with various attributes (e.g. stdout, ...

10 years, 3 months ago (2010-09-10 19:00:09 UTC) #1

davidjames

10 years, 3 months ago (2010-09-10 21:42:56 UTC) #2

LGTM. Please send a note to everybody in the Chromite hackathon group to let
them know that this is a breaking change to the interface, so they will need to
update any pending CLs.

Expand Messages | Collapse Messages