Don't launch service process if it's already running

Don't launch service process if it's already running

BUG=52891
TEST=browser_tests --gtest_filter=ServiceProcess*

Removed ServiceProcessControl::Connect() and just have a Launch() method.
The Launch() method will connect to the service process if the it has
already been launched but not connected. The method will
simply return if the process is already been launched connected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58265

[sanjeevr, 2010-09-01 18:07:27]

http://codereview.chromium.org/3306001/diff/2001/3001
File chrome/browser/service/service_process_control.cc (right):

http://codereview.chromium.org/3306001/diff/2001/3001#newcode125
chrome/browser/service/service_process_control.cc:125: // If the channel has
already been established then return.
This code seems to be the same as the one in ConnectInternal. Maybe we can
delete this code?

http://codereview.chromium.org/3306001/diff/2001/3001#newcode134
chrome/browser/service/service_process_control.cc:134: // If the service process
is already running then connets to it.
Nit: connets => connects

[Alpha Left Google, 2010-09-01 18:54:58]

http://codereview.chromium.org/3306001/diff/2001/3001
File chrome/browser/service/service_process_control.cc (right):

http://codereview.chromium.org/3306001/diff/2001/3001#newcode125
chrome/browser/service/service_process_control.cc:125: // If the channel has
already been established then return.
On 2010/09/01 18:07:27, sanjeevr wrote:
> This code seems to be the same as the one in ConnectInternal. Maybe we can
> delete this code?

Done.

http://codereview.chromium.org/3306001/diff/2001/3001#newcode134
chrome/browser/service/service_process_control.cc:134: // If the service process
is already running then connets to it.
On 2010/09/01 18:07:27, sanjeevr wrote:
> Nit: connets => connects

Done.

[sanjeevr, 2010-09-01 20:44:55]

LGTM