Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/gtk/options/general_page_gtk.cc

Issue 3304015: Use PrefChangeRegistrar everywhere (Closed)
Patch Set: final version for commit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/options/general_page_gtk.h" 5 #include "chrome/browser/gtk/options/general_page_gtk.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 InitHomepageGroup(), false); 88 InitHomepageGroup(), false);
89 options_builder->AddOptionGroup( 89 options_builder->AddOptionGroup(
90 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME), 90 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME),
91 InitDefaultSearchGroup(), false); 91 InitDefaultSearchGroup(), false);
92 #if !defined(OS_CHROMEOS) 92 #if !defined(OS_CHROMEOS)
93 options_builder->AddOptionGroup( 93 options_builder->AddOptionGroup(
94 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME), 94 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME),
95 InitDefaultBrowserGroup(), false); 95 InitDefaultBrowserGroup(), false);
96 #endif 96 #endif
97 97
98 profile->GetPrefs()->AddPrefObserver(prefs::kRestoreOnStartup, this); 98 registrar_.Init(profile->GetPrefs());
99 profile->GetPrefs()->AddPrefObserver(prefs::kURLsToRestoreOnStartup, this); 99 registrar_.Add(prefs::kRestoreOnStartup, this);
100 registrar_.Add(prefs::kURLsToRestoreOnStartup, this);
100 101
101 new_tab_page_is_home_page_.Init(prefs::kHomePageIsNewTabPage, 102 new_tab_page_is_home_page_.Init(prefs::kHomePageIsNewTabPage,
102 profile->GetPrefs(), this); 103 profile->GetPrefs(), this);
103 homepage_.Init(prefs::kHomePage, profile->GetPrefs(), this); 104 homepage_.Init(prefs::kHomePage, profile->GetPrefs(), this);
104 show_home_button_.Init(prefs::kShowHomeButton, profile->GetPrefs(), this); 105 show_home_button_.Init(prefs::kShowHomeButton, profile->GetPrefs(), this);
105 106
106 // Load initial values 107 // Load initial values
107 NotifyPrefChanged(NULL); 108 NotifyPrefChanged(NULL);
108 } 109 }
109 110
110 GeneralPageGtk::~GeneralPageGtk() { 111 GeneralPageGtk::~GeneralPageGtk() {
111 profile()->GetPrefs()->RemovePrefObserver(prefs::kRestoreOnStartup, this);
112 profile()->GetPrefs()->RemovePrefObserver(
113 prefs::kURLsToRestoreOnStartup, this);
114
115 if (template_url_model_) 112 if (template_url_model_)
116 template_url_model_->RemoveObserver(this); 113 template_url_model_->RemoveObserver(this);
117 114
118 default_browser_worker_->ObserverDestroyed(); 115 default_browser_worker_->ObserverDestroyed();
119 } 116 }
120 117
121 /////////////////////////////////////////////////////////////////////////////// 118 ///////////////////////////////////////////////////////////////////////////////
122 // GeneralPageGtk, OptionsPageBase overrides: 119 // GeneralPageGtk, OptionsPageBase overrides:
123 120
124 void GeneralPageGtk::NotifyPrefChanged(const std::string* pref_name) { 121 void GeneralPageGtk::NotifyPrefChanged(const std::string* pref_name) {
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 if (color) { 711 if (color) {
715 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup, 712 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup,
716 color, text.c_str()); 713 color, text.c_str());
717 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup); 714 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup);
718 g_free(markup); 715 g_free(markup);
719 } 716 }
720 717
721 gtk_widget_set_sensitive(default_browser_use_as_default_button_, 718 gtk_widget_set_sensitive(default_browser_use_as_default_button_,
722 state == ShellIntegration::STATE_NOT_DEFAULT); 719 state == ShellIntegration::STATE_NOT_DEFAULT);
723 } 720 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/options/general_page_gtk.h ('k') | chrome/browser/host_content_settings_map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698