Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/cocoa/preferences_window_controller.h

Issue 3304015: Use PrefChangeRegistrar everywhere (Closed)
Patch Set: final version for commit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_ptr.h" 7 #include "base/scoped_ptr.h"
8 #include "base/scoped_nsobject.h" 8 #include "base/scoped_nsobject.h"
9 #include "chrome/browser/options_window.h" 9 #include "chrome/browser/options_window.h"
10 #include "chrome/browser/prefs/pref_member.h" 10 #include "chrome/browser/prefs/pref_member.h"
11 #include "chrome/browser/prefs/pref_set_observer.h" 11 #include "chrome/browser/prefs/pref_set_observer.h"
12 #include "chrome/browser/prefs/pref_change_registrar.h"
12 13
13 namespace PreferencesWindowControllerInternal { 14 namespace PreferencesWindowControllerInternal {
14 class PrefObserverBridge; 15 class PrefObserverBridge;
15 class ManagedPrefsBannerState; 16 class ManagedPrefsBannerState;
16 } 17 }
17 18
18 @class CustomHomePagesModel; 19 @class CustomHomePagesModel;
19 @class FontLanguageSettingsController; 20 @class FontLanguageSettingsController;
20 class PrefService; 21 class PrefService;
21 class Profile; 22 class Profile;
(...skipping 16 matching lines...) Expand all
38 // to unit test). 39 // to unit test).
39 @interface PreferencesWindowController : NSWindowController { 40 @interface PreferencesWindowController : NSWindowController {
40 @private 41 @private
41 Profile* profile_; // weak ref 42 Profile* profile_; // weak ref
42 OptionsPage initialPage_; 43 OptionsPage initialPage_;
43 PrefService* prefs_; // weak ref - Obtained from profile_ for convenience. 44 PrefService* prefs_; // weak ref - Obtained from profile_ for convenience.
44 // weak ref - Also obtained from profile_ for convenience. May be NULL. 45 // weak ref - Also obtained from profile_ for convenience. May be NULL.
45 ProfileSyncService* syncService_; 46 ProfileSyncService* syncService_;
46 scoped_ptr<PreferencesWindowControllerInternal::PrefObserverBridge> 47 scoped_ptr<PreferencesWindowControllerInternal::PrefObserverBridge>
47 observer_; // Watches for pref changes. 48 observer_; // Watches for pref changes.
49 PrefChangeRegistrar registrar_; // Manages pref change observer registration.
48 scoped_nsobject<WindowSizeAutosaver> sizeSaver_; 50 scoped_nsobject<WindowSizeAutosaver> sizeSaver_;
49 NSView* currentPrefsView_; // weak ref - current prefs page view. 51 NSView* currentPrefsView_; // weak ref - current prefs page view.
50 scoped_ptr<PreferencesWindowControllerInternal::ManagedPrefsBannerState> 52 scoped_ptr<PreferencesWindowControllerInternal::ManagedPrefsBannerState>
51 bannerState_; 53 bannerState_;
52 BOOL managedPrefsBannerVisible_; 54 BOOL managedPrefsBannerVisible_;
53 55
54 IBOutlet NSToolbar* toolbar_; 56 IBOutlet NSToolbar* toolbar_;
55 IBOutlet VerticalGradientView* managedPrefsBannerView_; 57 IBOutlet VerticalGradientView* managedPrefsBannerView_;
56 IBOutlet NSImageView* managedPrefsBannerWarningImage_; 58 IBOutlet NSImageView* managedPrefsBannerWarningImage_;
57 59
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 231
230 // Returns the (normalized) page corresponding to the given toolbar item. 232 // Returns the (normalized) page corresponding to the given toolbar item.
231 // Should be called only after awakeFromNib is. 233 // Should be called only after awakeFromNib is.
232 - (OptionsPage)getPageForToolbarItem:(NSToolbarItem*)toolbarItem; 234 - (OptionsPage)getPageForToolbarItem:(NSToolbarItem*)toolbarItem;
233 235
234 // Returns the view corresponding to the given page. Should be called 236 // Returns the view corresponding to the given page. Should be called
235 // only after awakeFromNib is. 237 // only after awakeFromNib is.
236 - (NSView*)getPrefsViewForPage:(OptionsPage)page; 238 - (NSView*)getPrefsViewForPage:(OptionsPage)page;
237 239
238 @end 240 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698