Issue 3304013: Add client_prefix (string) and old_prefix (bool) command line options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3304013: Add client_prefix (string) and old_prefix (bool) command line options (Closed)

Created:
10 years, 3 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Add client_prefix (string) and old_prefix (bool) command line options cros_copy_upgrade_server can now start the devserver with either prefix. This is to help the migration from Memento to ChromeOSUpdateEngine. BUG=none TEST=none (yet)

Patch Set 1 #

Patch Set 2 : Nasty command line ordering #

Patch Set 3 : Tar up more utils #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	bin/cros_copy_upgrade_server.sh	View	1 2	3 chunks	+11 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Stewart

Hi Sam. PTAL. This version now works for me and I don't need cgpt in ...

10 years, 3 months ago (2010-09-09 02:36:22 UTC) #1

Sam Leffler

10 years, 3 months ago (2010-09-09 18:41:34 UTC) #2

LGTM pending TESTing

http://codereview.chromium.org/3304013/diff/4001/5001
File bin/cros_copy_upgrade_server.sh (right):

http://codereview.chromium.org/3304013/diff/4001/5001#newcode150
bin/cros_copy_upgrade_server.sh:150: ssh ${FLAGS_upgrade_server} "cd
${FLAGS_dest_path}/src/scripts && env
PYTHONPATH=${remote_root}${FLAGS_dest_path}/python
CHROMEOS_BUILD_ROOT=${archive_dir} ./start_devserver --archive_dir
${archive_dir} --client_prefix ${FLAGS_client_prefix} $server_port" >
$server_logfile 2>&1 &
add a comment about fixed parameter ordering

Expand Messages | Collapse Messages