Issue 3304012: Don't generate preparse data if lazy-flag is false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3304012: Don't generate preparse data if lazy-flag is false. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Don't generate preparse data if lazy-flag is false.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comment. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/compiler.cc	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 3 months ago (2010-09-08 10:08:13 UTC) #2

LGTM when comment is addressed.

http://codereview.chromium.org/3304012/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/3304012/diff/1/2#newcode274
src/compiler.cc:274: if (pre_data == NULL && FLAG_lazy &&
Could you do one part of the conjunction per line?

Also, the comment above needs to be updated. You should state why preparsing
does not make sense when lazy compilation is disabled.

Expand Messages | Collapse Messages