monitor_reconfig: Handle external monitors and add tests.

monitor_reconfig: Handle external monitors and add tests.

This splits the resolution-choosing logic out into its own 
class to make it easier to test.  It also adds some 
probably-unreliable heuristics to try to guess when the user
would rather that we just use the external output's maximum
resolution instead of trying to find a resolution that'll 
also work on the built-in output.

BUG=chromium-os:2933
TEST=added a bunch

[Daniel Erat, 2010-09-08 05:05:22]

I'm planning to follow this up with a change to make the resolution selection
logic more sophisticated and add more tests.  I'll probably need to do some
additional Makefile and/or ebuild fiddling before checking this in.

[Daniel Erat, 2010-09-08 11:20:57]

On 2010/09/08 05:05:22, Daniel Erat wrote:
> I'm planning to follow this up with a change to make the resolution selection
> logic more sophisticated and add more tests.  I'll probably need to do some
> additional Makefile and/or ebuild fiddling before checking this in.

My additional changes were actually very straightforward, so I just rolled them
into this change and added more tests.

[Daniel Erat, 2010-09-10 23:41:07]

ping

On 2010/09/08 11:20:57, Daniel Erat wrote:
> On 2010/09/08 05:05:22, Daniel Erat wrote:
> > I'm planning to follow this up with a change to make the resolution
selection
> > logic more sophisticated and add more tests.  I'll probably need to do some
> > additional Makefile and/or ebuild fiddling before checking this in.
> 
> My additional changes were actually very straightforward, so I just rolled
them
> into this change and added more tests.

[sosa, 2010-09-11 00:02:49]

Tests look great, nits, LGTM

http://codereview.chromium.org/3304011/diff/3001/4004
File resolution_selector.cc (right):

http://codereview.chromium.org/3304011/diff/3001/4004#newcode47
resolution_selector.cc:47: if (max_external_size >= kMinExternalMonitorPixels) {
I know this is just a heuristic but it seems more fair to compare against the
kMaxProjectPixels since we are looking at the max res

http://codereview.chromium.org/3304011/diff/3001/4006
File resolution_selector_test.cc (right):

http://codereview.chromium.org/3304011/diff/3001/4006#newcode69
resolution_selector_test.cc:69: EXPECT_EQ("1024x768", screen_resolution_);
check for cleared external resolution?

[Daniel Erat, 2010-09-11 01:48:56]

Thanks!

http://codereview.chromium.org/3304011/diff/3001/4004
File resolution_selector.cc (right):

http://codereview.chromium.org/3304011/diff/3001/4004#newcode47
resolution_selector.cc:47: if (max_external_size >= kMinExternalMonitorPixels) {
On 2010/09/11 00:02:50, sosa wrote:
> I know this is just a heuristic but it seems more fair to compare against the
> kMaxProjectPixels since we are looking at the max res

Done.

http://codereview.chromium.org/3304011/diff/3001/4006
File resolution_selector_test.cc (right):

http://codereview.chromium.org/3304011/diff/3001/4006#newcode69
resolution_selector_test.cc:69: EXPECT_EQ("1024x768", screen_resolution_);
On 2010/09/11 00:02:50, sosa wrote:
> check for cleared external resolution?

Done.