Issue 3303004: Convert all print statements to use options.stdout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3303004: Convert all print statements to use options.stdout. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Convert all print statements to use options.stdout. Needed to fix a few function calls to make it work. BUG=54084 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58287

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -71 lines)			Patch
	M	gclient_scm.py	View		32 chunks	+83 lines, -71 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/3303004/diff/1/2 File gclient_scm.py (right): http://codereview.chromium.org/3303004/diff/1/2#newcode27 gclient_scm.py:27: def __init__(self, relpath, stdout): Did you want this ...

10 years, 3 months ago (2010-09-01 20:15:54 UTC) #2

M-A Ruel

http://codereview.chromium.org/3303004/diff/1/2 File gclient_scm.py (right): http://codereview.chromium.org/3303004/diff/1/2#newcode27 gclient_scm.py:27: def __init__(self, relpath, stdout): On 2010/09/01 20:15:54, bradn wrote: ...

10 years, 3 months ago (2010-09-01 23:45:35 UTC) #3

bradn

10 years, 3 months ago (2010-09-01 23:48:34 UTC) #4

lg

On Wed, Sep 1, 2010 at 4:45 PM, <maruel@chromium.org> wrote:

>
> http://codereview.chromium.org/3303004/diff/1/2
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/3303004/diff/1/2#newcode27
> gclient_scm.py:27: def __init__(self, relpath, stdout):
> On 2010/09/01 20:15:54, bradn wrote:
>
>> Did you want this to have  a default of sys.stdout ?
>>
>
> No.
>
>
> http://codereview.chromium.org/3303004/show
>

Expand Messages | Collapse Messages