Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 3303002: Prepare push of version 2.4.0 to trunk. Now working on version 2.4.1. (Closed)

Created:
10 years, 3 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Prepare push of version 2.4.0 to trunk. Now working on version 2.4.1. Committed: http://code.google.com/p/v8/source/detail?r=5387

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years, 3 months ago (2010-09-01 06:29:19 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/3303002/diff/1/2 File ChangeLog (right): http://codereview.chromium.org/3303002/diff/1/2#newcode6 ChangeLog:6: Update Array.splice to follow Safari and firefox when ...
10 years, 3 months ago (2010-09-01 06:32:39 UTC) #2
Rico
10 years, 3 months ago (2010-09-01 06:37:16 UTC) #3
http://codereview.chromium.org/3303002/diff/1/2
File ChangeLog (right):

http://codereview.chromium.org/3303002/diff/1/2#newcode6
ChangeLog:6: Update Array.splice to follow Safari and firefox when called
On 2010/09/01 06:32:39, Kasper Lund wrote:
> firefox => Firefox

Done.

http://codereview.chromium.org/3303002/diff/1/2#newcode9
ChangeLog:9: Fix a missing live register when breaking at ARM keyed load.
On 2010/09/01 06:32:39, Kasper Lund wrote:
> at keyed loads on ARM.

Done.

Powered by Google App Engine
This is Rietveld 408576698