Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 3302012: Move stack check after while statement. (Closed)

Created:
10 years, 3 months ago by podivilov
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move stack check below while statement. Call to Runtime_StackGuard should be generated after loop body. Otherwise, break position will be the previous position before loop statement. Committed: http://code.google.com/p/v8/source/detail?r=5423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/full-codegen.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
podivilov
10 years, 3 months ago (2010-09-07 11:57:29 UTC) #1
Søren Thygesen Gjesse
10 years, 3 months ago (2010-09-07 14:15:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698