Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/download_uitest.cc

Issue 3302001: Disable DownloadTest.NewWindow everywhere. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_uitest.cc
diff --git a/chrome/browser/download/download_uitest.cc b/chrome/browser/download/download_uitest.cc
index 620855c7192c9277b0f6d89a91cf13e26c281f7c..3156027e670bc856ce31bb17017c0a04e8369a0f 100644
--- a/chrome/browser/download/download_uitest.cc
+++ b/chrome/browser/download/download_uitest.cc
@@ -512,15 +512,9 @@ TEST_F(DownloadTest, DISABLED_DontCloseNewWindow) {
CheckDownload(file);
}
-// http://crbug.com/50060
-#if defined(OS_MACOSX) || defined(OS_LINUX)
-#define MAYBE_NewWindow DISABLED_NewWindow
-#else
-#define MAYBE_NewWindow NewWindow
-#endif
-
// Regression test for http://crbug.com/44454
-TEST_F(DownloadTest, MAYBE_NewWindow) {
+// See also http://crbug.com/50060.
+TEST_F(DownloadTest, DISABLED_NewWindow) {
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
ASSERT_TRUE(browser.get());
int window_count = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698