Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3301019: Move sqlite preprocessed directory one level up, it's not from upstream.... (Closed)

Created:
10 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move sqlite preprocessed directory one level up, it's not from upstream. This is a follow-up to one of my earlier patches. TEST=none BUG=22208, 50769 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59717

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : more bot-friendly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/sqlite/google_generate_preprocessed.sh View 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/sqlite/preprocessed/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/keywordhash.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/opcodes.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/opcodes.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/parse.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/parse.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/sqlite/preprocessed/sqlite3.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite3.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
10 years, 3 months ago (2010-09-10 21:08:30 UTC) #1
Paweł Hajdan Jr.
Please note the files are svn mv-ed. For some reason Rietveld/gcl thinks they are deleted.
10 years, 3 months ago (2010-09-10 21:09:11 UTC) #2
Scott Hess - ex-Googler
I think you need to adjust the path in google_generate_preprocessed.sh, too. It was probably already ...
10 years, 3 months ago (2010-09-10 21:16:31 UTC) #3
Paweł Hajdan Jr.
PTAL
10 years, 3 months ago (2010-09-10 21:31:28 UTC) #4
Paweł Hajdan Jr.
Oh wait, it seems to break compile on Win. Weird. On Fri, Sep 10, 2010 ...
10 years, 3 months ago (2010-09-10 21:33:49 UTC) #5
Paweł Hajdan Jr.
PTAL, I think I've fixed problems caused by my mistakes.
10 years, 3 months ago (2010-09-16 01:04:11 UTC) #6
Scott Hess - ex-Googler
10 years, 3 months ago (2010-09-16 20:41:38 UTC) #7 
lgtm.

Powered by Google App Engine
This is Rietveld 408576698