Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 3301007: Fixed OpenBSD build. (Closed)

Created:
10 years, 3 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
Satish, Peter Valchev
CC:
chromium-reviews, scherkus (not reviewing), fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

Fixed OpenBSD build. Compilation on OpenBSD was broken by previous commits in the audio code. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58276

Patch Set 1 #

Total comments: 4

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M media/audio/openbsd/audio_manager_openbsd.h View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.cc View 1 2 2 chunks +5 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
Didn't try to compile it (don't have OBSD machine). Pavel, can you please check if ...
10 years, 3 months ago (2010-09-01 23:09:37 UTC) #1
Satish
LGTM http://codereview.chromium.org/3301007/diff/1/2 File media/audio/openbsd/audio_manager_openbsd.cc (right): http://codereview.chromium.org/3301007/diff/1/2#newcode29 media/audio/openbsd/audio_manager_openbsd.cc:29: AudioInputStream* AudioManagerOpenBSD::MakeAudioInputStream( add newline between the functions http://codereview.chromium.org/3301007/diff/1/3 ...
10 years, 3 months ago (2010-09-01 23:15:19 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/3301007/diff/1/2 File media/audio/openbsd/audio_manager_openbsd.cc (right): http://codereview.chromium.org/3301007/diff/1/2#newcode29 media/audio/openbsd/audio_manager_openbsd.cc:29: AudioInputStream* AudioManagerOpenBSD::MakeAudioInputStream( On 2010/09/01 23:15:19, Satish wrote: > add ...
10 years, 3 months ago (2010-09-01 23:17:38 UTC) #3
Peter Valchev
10 years, 3 months ago (2010-09-01 23:28:19 UTC) #4
LGTM

there are many other changes that currently prevent it from compiling on
OpenBSD, but i think this helps so i'd love it to be submitted. thanks!

On 2010/09/01 23:09:37, sergeyu wrote:
> Didn't try to compile it (don't have OBSD machine). Pavel, can you please
check
> if chrome compiles with this fix? Thanks!

Powered by Google App Engine
This is Rietveld 408576698