GTTF: Disable all download tests, they are broken just so much.

chrome/browser/download/download_uitest.cc

Index: chrome/browser/download/download_uitest.cc
diff --git a/chrome/browser/download/download_uitest.cc b/chrome/browser/download/download_uitest.cc
index 3156027e670bc856ce31bb17017c0a04e8369a0f..22fef7ac6b1b5aa4359a814257ac7bf0b5468bfb 100644
--- a/chrome/browser/download/download_uitest.cc
+++ b/chrome/browser/download/download_uitest.cc
@@ -172,9 +172,10 @@ class DownloadTest : public UITest {
 
 // Download a file with non-viewable content, verify that the
 // download tab opened and the file exists.
-// All download tests are disabled on all platforms, http://crbug.com/35275.
+// All download tests are disabled on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_DownloadMimeType) {
+TEST_F(DownloadTest, DISABLED_DownloadMimeType) {
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
 
   EXPECT_EQ(1, GetTabCount());
@@ -192,9 +193,10 @@ TEST_F(DownloadTest, FLAKY_DownloadMimeType) {
 
 // Access a file with a viewable mime-type, verify that a download
 // did not initiate.
-// All download tests are flaky on all platforms, http://crbug.com/35275.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_NoDownload) {
+TEST_F(DownloadTest, DISABLED_NoDownload) {
   FilePath file(FILE_PATH_LITERAL("download-test2.html"));
   FilePath file_path = download_prefix_.Append(file);
 
@@ -219,9 +221,10 @@ TEST_F(DownloadTest, FLAKY_NoDownload) {
 // Download a 0-size file with a content-disposition header, verify that the
 // download tab opened and the file exists as the filename specified in the
 // header.  This also ensures we properly handle empty file downloads.
-// All download tests are flaky on all platforms, http://crbug.com/35275.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_ContentDisposition) {
+TEST_F(DownloadTest, DISABLED_ContentDisposition) {
   FilePath file(FILE_PATH_LITERAL("download-test3.gif"));
   FilePath download_file(FILE_PATH_LITERAL("download-test3-attachment.gif"));
 
@@ -240,9 +243,10 @@ TEST_F(DownloadTest, FLAKY_ContentDisposition) {
 // tab, opening a second tab, closing the shelf, going back to the first tab,
 // and checking that the shelf is closed.
 // See bug http://crbug.com/26325
-// All download tests are flaky on all platforms, http://crbug.com/35275.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_PerWindowShelf) {
+TEST_F(DownloadTest, DISABLED_PerWindowShelf) {
   FilePath file(FILE_PATH_LITERAL("download-test3.gif"));
   FilePath download_file(FILE_PATH_LITERAL("download-test3-attachment.gif"));
 
@@ -281,9 +285,10 @@ TEST_F(DownloadTest, FLAKY_PerWindowShelf) {
 // The test will first attempt to download a file; but the server will "pause"
 // in the middle until the server receives a second request for
 // "download-finish.  At that time, the download will finish.
-// All download tests are flaky on all platforms, http://crbug.com/35275.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_UnknownSize) {
+TEST_F(DownloadTest, DISABLED_UnknownSize) {
   GURL url(URLRequestSlowDownloadJob::kUnknownSizeUrl);
   FilePath filename;
   net::FileURLToFilePath(url, &filename);
@@ -292,8 +297,10 @@ TEST_F(DownloadTest, FLAKY_UnknownSize) {
               L"100% - " + filename.ToWStringHack());
 }
 
-// http://crbug.com/35275
-TEST_F(DownloadTest, FLAKY_KnownSize) {
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
+TEST_F(DownloadTest, DISABLED_KnownSize) {
   GURL url(URLRequestSlowDownloadJob::kKnownSizeUrl);
   FilePath filename;
   net::FileURLToFilePath(url, &filename);
@@ -304,9 +311,10 @@ TEST_F(DownloadTest, FLAKY_KnownSize) {
 
 // Test that when downloading an item in Incognito mode, we don't crash when
 // closing the last Incognito window (http://crbug.com/13983).
-// All download tests are flaky on all platforms, http://crbug.com/35275.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
 // Additionally, there is Windows-specific flake, http://crbug.com/20809.
-TEST_F(DownloadTest, FLAKY_IncognitoDownload) {
+TEST_F(DownloadTest, DISABLED_IncognitoDownload) {
   // Open a regular window and sanity check default values for window / tab
   // count and shelf visibility.
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
@@ -351,6 +359,9 @@ TEST_F(DownloadTest, FLAKY_IncognitoDownload) {
 }
 
 // All of the following tests are disabled, see http://crbug.com/43066
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_DontCloseNewTab1) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -370,6 +381,9 @@ TEST_F(DownloadTest, DISABLED_DontCloseNewTab1) {
   WaitUntilTabCount(2);
 }
 
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_CloseNewTab1) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -393,6 +407,9 @@ TEST_F(DownloadTest, DISABLED_CloseNewTab1) {
 }
 
 // Disabled, see http://crbug.com/43066
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_DontCloseNewTab2) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -417,6 +434,9 @@ TEST_F(DownloadTest, DISABLED_DontCloseNewTab2) {
 }
 
 // Flaky, see http://crbug.com/43066
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_DontCloseNewTab3) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -444,6 +464,9 @@ TEST_F(DownloadTest, DISABLED_DontCloseNewTab3) {
 }
 
 // Flaky, see http://crbug.com/43066
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_CloseNewTab2) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -468,6 +491,9 @@ TEST_F(DownloadTest, DISABLED_CloseNewTab2) {
 }
 
 // Flaky, see http://crbug.com/43066
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_CloseNewTab3) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -492,6 +518,9 @@ TEST_F(DownloadTest, DISABLED_CloseNewTab3) {
   CheckDownload(file);
 }
 
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_DontCloseNewWindow) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
@@ -514,6 +543,9 @@ TEST_F(DownloadTest, DISABLED_DontCloseNewWindow) {
 
 // Regression test for http://crbug.com/44454
 // See also http://crbug.com/50060.
+// All download tests are flaky on all platforms, http://crbug.com/35275,
+// http://crbug.com/48913 and especially http://crbug.com/50060.
+// Additionally, there is Windows-specific flake, http://crbug.com/20809.
 TEST_F(DownloadTest, DISABLED_NewWindow) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());