Issue 3301006: GTTF: Disable all download tests, they are broken just so much.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3301006: GTTF: Disable all download tests, they are broken just so much. (Closed)

Created:
10 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
ahendrickson

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

GTTF: Disable all download tests, they are broken just so much. They don't wait until the download finishes, so a "do you want to close the browser, you have pending downloads?" dialog appears, which makes buildbots leak a process and become hosed. TBR=ahendrickson BUG=35275, 48913, 50060 TEST=ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58225

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
	M	chrome/browser/download/download_uitest.cc	View		15 chunks	+46 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahendrickson

Should we put in code that prevents the dialog from appearing during unit tests?

10 years, 3 months ago (2010-09-01 20:43:47 UTC) #2

Paweł Hajdan Jr.

10 years, 3 months ago (2010-09-02 01:16:26 UTC) #3

non-trivial. Generally those tests are known to be broken, and we get most of
the coverage from pyauto. Actually the failure that lead me to disable them was
real, but it was still flaky, and even without that bug it would have some low,
non-zero probability of occurring.

Expand Messages | Collapse Messages