Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 330026: Http cache: Handle byte range requests when there is no cache entry.... (Closed)

Created:
11 years, 1 month ago by rvargas (doing something else)
Modified:
7 years, 6 months ago
Reviewers:
fbarchard, eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Http cache: Handle byte range requests when there is no cache entry. BUG=25837 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30165

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/net/chrome_url_request_context.cc View 2 3 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_cache.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fbarchard
this helps avoid the instant crash, but I still get an 'aw snap' about 10 ...
11 years, 1 month ago (2009-10-27 02:06:54 UTC) #1
rvargas (doing something else)
yes, I'm also seeing that... and nothing after the first frame. On 2009/10/27 02:06:54, fbarchard ...
11 years, 1 month ago (2009-10-27 02:11:20 UTC) #2
fbarchard
nevermind... theres a crash and a hang that are not related to your change. your ...
11 years, 1 month ago (2009-10-27 02:17:02 UTC) #3
fbarchard
LGTM There may be another issue with with byte range support that affects how quickly ...
11 years, 1 month ago (2009-10-27 02:25:54 UTC) #4
rvargas (doing something else)
11 years, 1 month ago (2009-10-27 04:01:24 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698