Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 330014: [mac] Send cmd-c and friends back to browser. (Closed)

Created:
11 years, 1 month ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[mac] Send cmd-c and friends back to browser. Fixes cmd-c, cmd-v, cmd-x, cmd-a. The menu blinking is worth the extra IPC hop. BUG=25254 TEST=Select text, hit cmd-c. "Edit" menu should blink. Hit cmd-v. "Edit" menu should blink again, correct text should be pasted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30045 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=30046 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30079

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : foo #

Patch Set 4 : foo! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M webkit/glue/editor_client_impl.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/keyboard_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
11 years, 1 month ago (2009-10-26 05:03:51 UTC) #1
Avi (use Gerrit)
LG
11 years, 1 month ago (2009-10-26 13:50:13 UTC) #2
Nico
I had to make a change to test_shell to make tests pass. This change means ...
11 years, 1 month ago (2009-10-26 15:59:59 UTC) #3
Nico
Oh, that was supposed to mean "please re-review" btw :-)
11 years, 1 month ago (2009-10-26 17:03:53 UTC) #4
Avi (use Gerrit)
11 years, 1 month ago (2009-10-26 17:58:13 UTC) #5
SLG

Powered by Google App Engine
This is Rietveld 408576698