Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 3300030: Removed use of XmppSocketAdapter by sync. (Closed)

Created:
10 years, 3 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), Alpha Left Google, ben+cc_chromium.org, Sergey Ulanov, Raghu Simha, idana, dmac, pam+watch_chromium.org, awong, garykac, tim (not reviewing)
Visibility:
Public.

Description

Removed use of XmppSocketAdapter by sync. Moved XmppSocketAdapter and friends to remoting directory. Removed some dead code in jingle/. This is a relanding of 59012, which was mistakenly reverted at 59104. BUG=54146, 55116 TEST=none TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -533 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 8 chunks +7 lines, -36 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M jingle/jingle.gyp View 3 chunks +0 lines, -11 lines 0 comments Download
M jingle/notifier/base/notifier_options.h View 1 chunk +3 lines, -10 lines 0 comments Download
D jingle/notifier/base/signal_thread_task.h View 1 chunk +0 lines, -96 lines 0 comments Download
D jingle/notifier/base/static_assert.h View 1 chunk +0 lines, -21 lines 0 comments Download
M jingle/notifier/communicator/login.h View 2 chunks +0 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/login.cc View 4 chunks +1 line, -6 lines 0 comments Download
D jingle/notifier/communicator/product_info.h View 1 chunk +0 lines, -15 lines 0 comments Download
D jingle/notifier/communicator/product_info.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 2 chunks +1 line, -10 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.cc View 7 chunks +21 lines, -209 lines 0 comments Download
M jingle/notifier/communicator/xmpp_connection_generator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.cc View 4 chunks +0 lines, -46 lines 0 comments Download
M remoting/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/jingle_glue/jingle_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + remoting/jingle_glue/ssl_adapter.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + remoting/jingle_glue/ssl_adapter.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + remoting/jingle_glue/ssl_socket_adapter.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + remoting/jingle_glue/ssl_socket_adapter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + remoting/jingle_glue/xmpp_socket_adapter.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + remoting/jingle_glue/xmpp_socket_adapter.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698