Issue 3300020: Store pattern.length() in a local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3300020: Store pattern.length() in a local. (Closed)

Created:
10 years, 3 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Store pattern.length() in a local. Committed: http://code.google.com/p/v8/source/detail?r=5428

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -18 lines)			Patch
	M	src/runtime.cc	View	1	5 chunks	+21 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/3300020/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/3300020/diff/1/2#newcode2833 src/runtime.cc:2833: int plen = pattern.length(); Rename to "pattern_length". We ...

10 years, 3 months ago (2010-09-08 10:51:31 UTC) #2

sandholm

10 years, 3 months ago (2010-09-08 11:04:55 UTC) #3

http://codereview.chromium.org/3300020/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/3300020/diff/1/2#newcode2833
src/runtime.cc:2833: int plen = pattern.length();
On 2010/09/08 10:51:31, Lasse Reichstein wrote:
> Rename to "pattern_length". We try not to use too many abbreviations.

Done.

http://codereview.chromium.org/3300020/diff/1/2#newcode2883
src/runtime.cc:2883: int plen = pattern.length();
On 2010/09/08 10:51:31, Lasse Reichstein wrote:
> Ditto.

Done.

http://codereview.chromium.org/3300020/diff/1/2#newcode3050
src/runtime.cc:3050: int plen = pat.length();
On 2010/09/08 10:51:31, Lasse Reichstein wrote:
> And rename again (ahem, "pat" and "sub" should not be seen as an example to
copy
> :)

Done. Renamed pat and sub as well...

Expand Messages | Collapse Messages

Issue 3300020: Store pattern.length() in a local. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages