Issue 3300007: Do not blindly assume that a .gclient file in a parent directory belongs to t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3300007: Do not blindly assume that a .gclient file in a parent directory belongs to t... (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

Do not blindly assume that a .gclient file in a parent directory belongs to the current directory. BUG=54238 TEST=GClientSmoke.testWrongConfig Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58371

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	depot_tools/gclient.py	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
	M	depot_tools/tests/gclient_smoketest.py	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

jochen (gone - plz use gerrit)

The bug was that I used tree(false) which returns Dependency objects. The fix is to ...

10 years, 3 months ago (2010-09-02 15:35:39 UTC) #1

lgtm