Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: tests/threads/nacl.scons

Issue 3298014: Add a failing test for a race in newlib. (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/threads/newlib_stdio_test.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/threads/nacl.scons
===================================================================
--- tests/threads/nacl.scons (revision 3206)
+++ tests/threads/nacl.scons (working copy)
@@ -45,13 +45,23 @@
command=[env.File('simple_thread_test.nexe')],
size='small',
)
-# This test is extremely (and unpredictably) slow under Memcheck on the Karmic
-# buildbot because of what seems to be starvation on the critical section.
-# The second thread manages to acquire the CS only after ~30 seconds of
-# spinning.
-# Somehow this can not be reproduced on desktop machines.
env.AddNodeToTestSuite(node, TEST_SUITES, 'run_simple_thread_test')
+env.ComponentProgram('newlib_stdio_test.nexe',
+ 'newlib_stdio_test.c',
+ EXTRA_LIBS=['pthread'],
+ )
+node = env.CommandSelLdrTestNacl(
+ 'newlib_stdio_test.out',
+ command=[env.File('newlib_stdio_test.nexe')],
+ stdout_golden=env.File('newlib_stdio_test.stdout.golden'),
+ size='small',
+ )
+# This test currently fails because of a race in newlib between
+# __newlib_thread_init and __sinit.
+
+# env.AddNodeToTestSuite(node, TEST_SUITES, 'run_newlib_stdio_test')
krasin 2010/09/07 11:25:50 This test is flaky. Sometimes it fails, sometimes
+
env.ComponentProgram('race_test.nexe',
'race_test.c',
EXTRA_LIBS=['pthread'],
« no previous file with comments | « no previous file | tests/threads/newlib_stdio_test.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698