Issue 3298014: Add a failing test for a race in newlib.

Issue 3298014: Add a failing test for a race in newlib. (Closed)

Created:
10 years, 3 months ago by Evgeniy Stepanov

Modified:
9 years ago

Reviewers:
khimg, pasko-google - do not use, krasin

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Visibility:
Public.

Description

Add a failing test for a race in newlib.

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -5 lines)			Patch
M	tests/threads/nacl.scons	View	1 chunk	+15 lines, -5 lines	1 comment	Download
A	tests/threads/newlib_stdio_test.c	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	tests/threads/newlib_stdio_test.stdout.golden	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

krasin

http://codereview.chromium.org/3298014/diff/1/2 File tests/threads/nacl.scons (right): http://codereview.chromium.org/3298014/diff/1/2#newcode63 tests/threads/nacl.scons:63: # env.AddNodeToTestSuite(node, TEST_SUITES, 'run_newlib_stdio_test') This test is flaky. Sometimes ...

10 years, 3 months ago (2010-09-07 11:25:50 UTC) #3

pasko-google - do not use

On 2010/09/07 11:25:50, krasin wrote: > http://codereview.chromium.org/3298014/diff/1/2 > File tests/threads/nacl.scons (right): > > http://codereview.chromium.org/3298014/diff/1/2#newcode63 > ...

10 years, 3 months ago (2010-09-07 12:13:36 UTC) #4

Evgeniy Stepanov

On 2010/09/07 12:13:36, pasko wrote: > On 2010/09/07 11:25:50, krasin wrote: > > http://codereview.chromium.org/3298014/diff/1/2 > ...

10 years, 3 months ago (2010-09-07 12:15:49 UTC) #5

Evgeniy Stepanov

10 years, 3 months ago (2010-09-07 12:46:00 UTC) #6

On 2010/09/07 12:15:49, Evgeniy Stepanov wrote:
> On 2010/09/07 12:13:36, pasko wrote:
> > On 2010/09/07 11:25:50, krasin wrote:
> > > http://codereview.chromium.org/3298014/diff/1/2
> > > File tests/threads/nacl.scons (right):
> > > 
> > > http://codereview.chromium.org/3298014/diff/1/2#newcode63
> > > tests/threads/nacl.scons:63: # env.AddNodeToTestSuite(node, TEST_SUITES,
> > > 'run_newlib_stdio_test')
> > > This test is flaky. Sometimes it fails, sometimes it passes. It means,
that
> > you
> > > need to run it several times.
> > 
> > +1, flaky tests are bad :(
> 
> Yes. That's why it is disabled :)

Per offline discussion, I'm leaving this uncommitted.
It is linked from http://code.google.com/p/nativeclient/issues/detail?id=870.

Expand Messages | Collapse Messages