Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 3297011: Removes indexed_db_param_traits.h depedencies on WebKit headers. (Closed)

Created:
10 years, 3 months ago by bulach
Modified:
9 years, 7 months ago
Reviewers:
andreip3000, brettw, jorlow
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Removes indexed_db_param_traits.h depedencies on WebKit headers. BUG=53317 TEST=No functional change, compiler/linker should be happy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58971

Patch Set 1 : Patch #

Total comments: 4

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -73 lines) Patch
M chrome/browser/utility_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/indexed_db_param_traits.h View 2 chunks +10 lines, -73 lines 0 comments Download
A chrome/common/indexed_db_param_traits.cc View 1 1 chunk +96 lines, -0 lines 0 comments Download
M chrome/common/render_messages.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/utility_messages.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/utility_messages_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/utility_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bulach
this is a follow up on http://codereview.chromium.org/3043037, sorry it took so long (I was out ...
10 years, 3 months ago (2010-09-06 18:59:31 UTC) #1
brettw
LGTM, thanks. http://codereview.chromium.org/3297011/diff/2001/3003 File chrome/common/indexed_db_param_traits.cc (right): http://codereview.chromium.org/3297011/diff/2001/3003#newcode55 chrome/common/indexed_db_param_traits.cc:55: bool ParamTraits<IndexedDBKey>::Read( Style nit: since these fit, ...
10 years, 3 months ago (2010-09-07 16:42:51 UTC) #2
bulach
10 years, 3 months ago (2010-09-09 17:12:13 UTC) #3
thanks Brett! all comments addressed, landing soon.

http://codereview.chromium.org/3297011/diff/2001/3003
File chrome/common/indexed_db_param_traits.cc (right):

http://codereview.chromium.org/3297011/diff/2001/3003#newcode55
chrome/common/indexed_db_param_traits.cc:55: bool
ParamTraits<IndexedDBKey>::Read(
On 2010/09/07 16:42:51, brettw wrote:
> Style nit: since these fit, put the first param on the previous line, and the
> other ones directly under it aligned horizontally. Generally only wrap params
> for function decls and impls to 4 spaces when a param is too long to follow
the
> (.
> 
> Same above.

Done.

http://codereview.chromium.org/3297011/diff/2001/3003#newcode94
chrome/common/indexed_db_param_traits.cc:94: } // namespace IPC
On 2010/09/07 16:42:51, brettw wrote:
> Style nit: two spaces before // for end-of-line comments.

Done.

Powered by Google App Engine
This is Rietveld 408576698