Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3296013: Add Farsi support... (Closed)

Created:
10 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
mal, tony
CC:
chromium-reviews, finnur+watch_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add Farsi support Add 'fa' entry to all the grd files. For *locale_settings*, create new xtb files for Farsi (copied from Arabic). Also, pulls in ICU @r=58904 (with Farsi data). locale_settings_fa.xtb has a lot of UI dimensions that may not work well in Farsi. We need LQA to take a look at them. terms_FOO.html is not yet available for Farsi as well as Amharic and Swahili. Tentatively, use terms_en.html. BUG=45505 TEST='chrome --lang=fa' on Windows should bring up Chrome in Farsi. 'LANGUAGE=fa chrome' should do the same on Linux. (on Ubuntu, 'language-pack-gnome-fa' and 'language-pack-fa' have be installed to get Chrome in Farsi with the UI mirrored). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58998

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : add locales.gyp #

Patch Set 4 : include ICU revision update #

Patch Set 5 : add locale_settings*grd files not included earlier #

Patch Set 6 : use terms_en.html for now for fa,am,sw #

Patch Set 7 : remove am,sw terms change to put it in a separate CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M app/resources/app_locale_settings.grd View 3 chunks +3 lines, -0 lines 0 comments Download
A app/resources/app_locale_settings_fa.xtb View 1 chunk +5 lines, -0 lines 0 comments Download
M app/resources/app_strings.grd View 3 chunks +3 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromium_strings.grd View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/app/locales/locales.gyp View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 2 3 4 5 6 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_cros.grd View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/app/resources/locale_settings_fa.xtb View 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_linux.grd View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_cros_fa.xtb View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_linux_fa.xtb View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_mac_fa.xtb View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/app/resources/platform_locale_settings/locale_settings_win_fa.xtb View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/glue/devtools_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/inspector_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
10 years, 3 months ago (2010-09-08 23:21:50 UTC) #1
mal
LGTM. Thanks!
10 years, 3 months ago (2010-09-08 23:27:30 UTC) #2
tony
10 years, 3 months ago (2010-09-08 23:54:17 UTC) #3 
LGTM.  I think you also need to update chrome/app/locales/locales.gyp to get the
dll to build on windows.

Powered by Google App Engine
This is Rietveld 408576698